This repository has been archived by the owner on Oct 8, 2021. It is now read-only.
Fixes issue #3966 #3967
Merged
Fixes issue #3966 #3967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed duplicate/conflicting rules for .ui-mini.ui-btn-icon-[pos] .ui-btn-inner padding:
30px is consistent with fullsize buttons, where there is a bit more space between icon and text than between icon and border. So I used the 30px instead of 28px for all mini buttons including header/footer buttons.
Note: header/footer buttons with icon position bottom had a padding-bottom of 33px which was different from the left/right/top positioned icons (padding 28px). In case of fullsize buttons this is 40px all around. With 30px padding I don't think there is any need to adjust it for bottom positioned icons.
Added ui-icon positioning rules for ui-mini controlgroup buttons:
The checkbox/radio plugin has an inheritAttr function which provides the buttons within the controlgroup with the same date-attributes (including data-role="mini"). Since this is not the case with regular buttons, only the controlgroup has class ui-mini and not the buttons.
As a quick fix I copied the .ui-mini.ui-btn-icon-[pos] .ui-icon {[pos]: 5px; } rules and added a space after .ui-mini. Better solution would probably be having the JS adding the ui-mini class to the buttons.
One more thing. I noticed the ui-fullsize class. Looking at the JS function I suppose this class is assigned when data-mini="false" is used on header/footer buttons. Looking at the CSS I only see one generic rule:
.ui-header/footer .ui-fullsize .ui-btn-inner { font-size: 16px; padding: .6em 25px; }
Shouldn't there be specific icon position rules for this as well?